dont open the file on dav HEAD request #9559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
sabre-head-dont-open-file
branch
from
45aed74 to
9b9a576
Compare
Member
Author
|
rebased and updated to keep changes in line with upstream |
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
sabre-head-dont-open-file
branch
from
9b9a576 to
c8076f5
Compare
Member
|
rebased |
Codecov Report
@@ Coverage Diff @@
## master #9559 +/- ##
============================================
+ Coverage 51.15% 51.15% +<.01%
Complexity 25692 25692
============================================
Files 1568 1568
Lines 88039 88039
============================================
+ Hits 45036 45037 +1
+ Misses 43003 43002 -1
|
rullzer
approved these changes
May 26, 2018
Member
|
@icewind1991 Please backport to stable13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream version: sabre-io/dav#1058
Not only does opening the file lead to unneeded overhead, it also requires locking the file which can lead to locking conflicts.