Skip to content

[stable12] cleanup locks in scanner on error #9567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
May 23, 2018
Merged

[stable12] cleanup locks in scanner on error #9567

rullzer merged 1 commit into from
May 23, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented May 23, 2018

Backport of #9395

+1 from me

@icewind1991 @rullzer
cleanup locks in scanner on error
7c8e34f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer rullzer added enhancement 3. to review Waiting for reviews labels May 23, 2018
@rullzer rullzer added this to the Nextcloud 12.0.8 milestone May 23, 2018
@rullzer rullzer requested a review from MorrisJobke May 23, 2018 18:10
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 23, 2018
@codecov
Copy link

codecov bot commented May 23, 2018 •
edited
Loading

Codecov Report

Merging #9567 into stable12 will increase coverage by <.01%.
The diff coverage is 90%.

@@              Coverage Diff               @@
##             stable12    #9567      +/-   ##
==============================================
+ Coverage       53.93%   53.93%   +<.01%     
  Complexity      22813    22813              
==============================================
  Files            1389     1389              
  Lines           87398    87401       +3     
  Branches         1331     1331              
==============================================
+ Hits            47134    47141       +7     
+ Misses          40264    40260       -4
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Scanner.php 81.33% <90%> (-0.29%) 109 <0> (ø)
version.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/js.js 61.83% <0%> (+0.55%) 0% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@rullzer rullzer merged commit 3ebed2b into stable12 May 23, 2018
@rullzer rullzer deleted the backport/9395/stable12 branch May 23, 2018 21:04
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 12.0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @icewind1991