Emit event when running ./occ db:add-missing-indices #9576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
schiessle
juliusknorr
requested changes
May 24, 2018
| * @param IDBConnection $connection | ||
| */ | ||
| public function __construct(IDBConnection $connection) { | ||
| public function __construct(IDBConnection $connection, EventDispatcherInterface $dispatcher) { |
Member
There was a problem hiding this comment.
You're missing the assignment of $dispatcher to the private field.
rullzer
force-pushed
the
feature/noid/missing_index_event
branch
from
0830a8f to
91ec554
Compare
Codecov Report
@@ Coverage Diff @@
## master #9576 +/- ##
=============================================
+ Coverage 29.13% 51.18% +22.04%
Complexity 25673 25673
=============================================
Files 1568 1568
Lines 87950 87953 +3
=============================================
+ Hits 25623 45015 +19392
+ Misses 62327 42938 -19389
|
juliusknorr
approved these changes
May 24, 2018
MorrisJobke
added
4. to release
Member
|
Retriggered CI job |
MorrisJobke
reviewed
May 24, 2018
lib/public/IDBConnection.php
Outdated
| */ | ||
| interface IDBConnection { | ||
|
|
||
| const ADD_MISSING_INDEXES_EVENT = this::class . '::ADD_MISSING_INDEXES'; |
Member
There was a problem hiding this comment.
lib/public/IDBConnection.php:49 PhanUndeclaredClassConstant Reference to constant class from undeclared class \OCP\this
Member
There was a problem hiding this comment.
I fixed it by replacing the this with self 😉
This allows apps to listen to this event in order to also update indecies there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
feature/noid/missing_index_event
branch
from
91ec554 to
80cc8d0
Compare
Member
Author
|
Would a backport make sense? it is a small change but then apps can already add indexes for 13 apps. |
Member
I would say so. |
Member
Author
|
backport in #9620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows apps to listen to this event in order to also update
indecies there.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl