Skip to content

Fix drone mysqlmb4 tests #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
May 30, 2018
Merged

Fix drone mysqlmb4 tests #9670

rullzer merged 1 commit into from
May 30, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 30, 2018 •
edited
Loading

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

see: docker-library/mysql#303 (comment)

@skjnldsv
Fix drone mysqlmb4 tests
aec85bf 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this May 30, 2018
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label May 30, 2018
rullzer
rullzer approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do it like this for now

@codecov
Copy link

codecov bot commented May 30, 2018 •
edited
Loading

Codecov Report

Merging #9670 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9670      +/-   ##
============================================
+ Coverage     51.73%   51.73%   +<.01%     
  Complexity    25709    25709              
============================================
  Files          1635     1635              
  Lines         95963    95963              
  Branches       1384     1384              
============================================
+ Hits          49646    49647       +1     
+ Misses        46317    46316       -1
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.7% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2018
@rullzer rullzer merged commit e8c680f into master May 30, 2018
@rullzer rullzer deleted the drone-mysqlmb4-fix branch May 30, 2018 06:52
This was referenced May 30, 2018
Merged
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented May 30, 2018

Backports: #9671 #9672

@MorrisJobke
Copy link
Member

MorrisJobke commented May 30, 2018

Thanks - you rock

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@blizzz blizzz Awaiting requested review from blizzz

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @MorrisJobke @rullzer