Do not logout on auth on public share page #9756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
If the user is authenticated to cloudA. And then visits a password protected public link where we authenticate. We should rotate the token to the new session id. Else they have to reauthenticate Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
bugfix/noid/do_not_logout_on_public_share_auth
branch
from
c81f991 to
8da4fe3
Compare
Codecov Report
@@ Coverage Diff @@
## master #9756 +/- ##
=============================================
- Coverage 51.72% 29.96% -21.77%
+ Complexity 25753 24452 -1301
=============================================
Files 1638 1478 -160
Lines 96052 79956 -16096
Branches 1385 0 -1385
=============================================
- Hits 49682 23955 -25727
- Misses 46370 56001 +9631
|
rullzer
added
3. to review
| $this->session->regenerateId(); | ||
| $newId = $this->session->getId(); | ||
| try { | ||
| $this->tokenProvider->renewSessionToken($oldId, $newId); |
Member
There was a problem hiding this comment.
Do we really want to work with the provider directly here? IMO it should be handled via some kind of manager service. What do you think?
Member
Author
There was a problem hiding this comment.
This is just the quick fix. Once #9518 is in this all abstracted away from the users.
Member
Author
There was a problem hiding this comment.
But fair enough. Some manager in the public I terface to tackle this makes sense...
Member
Author
There was a problem hiding this comment.
Maybe an extra manager is overkill here. Can't we just add a parameter (or new function) to the ISession?
Member
Author
|
#9823 is probably better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is authenticated to cloudA. And then visits a password
protected public link where we authenticate. We should rotate the token
to the new session id. Else they have to reauthenticate
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl