-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
implement federated group sharing #9895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
589e17d to
037a610
Compare
Codecov Report
@@ Coverage Diff @@
## master #9895 +/- ##
============================================
- Coverage 51.4% 6.32% -45.09%
- Complexity 26411 26448 +37
============================================
Files 1690 1690
Lines 97712 97836 +124
Branches 1292 1290 -2
============================================
- Hits 50233 6184 -44049
- Misses 47479 91652 +44173
|
57beaba to
a6430f6
Compare
013cf99 to
7a36964
Compare
|
@schiessle Could you rebase to resolve the conflicts and have less changes as the other PR got merged. |
7a36964 to
4854965
Compare
|
@MorrisJobke just done 🙂 |
|
I would feel a lot more comfortable if you could extend (or copy) the federated integration tests and move them to group shares. Just so we know when it does 💥 |
bac6cad to
da020eb
Compare
|
@rullzer I added some integration tests. Now it is your turn 😉 |
|
Now the unit tests fail ;) |
|
And yay for tests! |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
da020eb to
412f6a6
Compare
|
@rullzer unit tests should be fixed now |
I added this to the OP 😉 |
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay lets do this!
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
Allows you to share a file/folder with a group on a different server. The group is addressed similiar to a individual user:
<groupname>@<server>. By default incoming and outgoing federated group shares are disabled in the admin settings.Fixes #4252