fix popover position #192
Merged
fix popover position #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Member
|
Isn't this somehow related to nextcloud/server#2545 ? |
Member
|
@jancborchardt you shouldn't need to position the popover if you use the guidelines I put in nextcloud/server#2545 :) |
skjnldsv
approved these changes
Dec 15, 2016
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Indeed, this works. But the best will be to add it like I said in the guidelines:
For référence: the popover menu should be inside the div containing the dots icon.
The required right distance to the border (or padding, whatever you want to use) of the three-dot icon should be 14px (5 for menu margin and 6 for arrow position)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before & after:
Please review @nextcloud/designers