Offset toastify when top bar is visible #5794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid overlapping with the top bar, the toastify notification is shifted down. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
1 task
nickvergessen
approved these changes
Jun 18, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Feels hacky, but looks nice and does the job.
Approving but lets wait for a frontender to confirm
Member
Author
|
a less hacky alternative would be to adjust nextcloud-dialogs to also pass the "offset" attribute through to Toastify, but then we also need to set it in every call to showMessage, maybe setup a wrapper function in Talk, or introduce global options for Toastify in nextcloud-dialogs for that. |
This was referenced Jun 18, 2021
Member
Author
|
tickets raised in nextcloud-dialogs:
|
marcoambrosini
approved these changes
Jun 18, 2021
Member
|
@PVince81 need to adjust something or unluckily revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overlapping with the top bar, the toastify notification is
shifted down.
Doesn't look that fantastic though, wondering if we should move the notifications to the bottom instead. The latter might need more involved changes as it would require support for global toastify options in nextcloud-dialogs.