Make training jobs time insensitive #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ChristophWurst
requested changes
Mar 30, 2022
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Needs checks because the main branch doesn't only target server master
Member
Author
|
what kind of checks ? method existence ? or set min-version to 23 ? |
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
train-job-time-insensitive
branch
from
9af794c to
efa96ff
Compare
Member
Author
|
thanks a lot. I've adjusted the two jobs, please re-review |
ChristophWurst
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608