Fix app navigation menu, closes #49 #53
Conversation
|
@skjnldsv would be awesome, if you could have a look 😄 |
| </button> | ||
| </div> | ||
| </div> | ||
| <div class="app-navigation-entry-menu bubble sortorder-dropdown"> |
There was a problem hiding this comment.
This is NOT a app-navigation-entry-menu, we're in the content, this should be a popovermenu 😉
Though this should roughly be similar, changing the class should be enough :)
The menu content on the other hand, seems to be broken (click action), so since we're working on this, maybe fix this too? 😄
There was a problem hiding this comment.
If you want to work on this in another pr, I will change my review to approved to merge this fast! ;)
There was a problem hiding this comment.
Maybe tackle this in a follow up PR, so that we have a usable state for the menu already. Right now, master is broken and with this PR it should be fine, "just" not fitting the guideline ;)
There was a problem hiding this comment.
The click on menu is broken too, this is not just the guidelines 😃
When you select a sort option, you can't click the button again (or with a lot of difficulties)
There was a problem hiding this comment.
Hm, I never considered this a bug. But I am ok with keeping the menu open after clicking the popover.
There was a problem hiding this comment.
No no, Im talking about the button, not the menu :)
There was a problem hiding this comment.
Sorry, I don't get what you mean. Clicking on the sort-order dropdown button opens the menu, clicking it again, closes it. When I click inside the popover, a sorttype is selected and the menu is closed. What is wrong about that? 😕
There was a problem hiding this comment.
Ahaha, sorry, you're right I'm not clear!
When you click the button, the popover opens, you can select an option and it closes right away, which is perfect!
BUT, after that, when you click the button again, it doesnt work. You need to click just under the icon. It doesn't work after that.
There was a problem hiding this comment.
Hm, I can't reproduce this behavior. After selecting an option I can open and close the menu just fine. It behaves the same as before. Could you maybe create an issue for that and tell me which browser you use?
|
Great, thanks for reviewing. Will tackle the popover problem asap. |
@skjnldsv Could you have a look here, please? I fixed the app navigation menu including the delete countdown.
The sortorder dropdown list needs some attention now, but I will do this in a follow up PR.I decided to fix the sortorder dropdown here too. Should be all good now.