Support NC12

[GitHubUser4234]

Hi,

Please release the mail template editor for NC 12, it's desperately needed, thanks!

[nickvergessen]

Well the main issue is, that the emails are now themed with the new email template system.
There for the files this app used do not exist anymore.

What exactly do you want to change?

[GitHubUser4234]

Well the main issue is, that the emails are now themed with the new email template system.
There for the files this app used do not exist anymore.

What exactly do you want to change?

The goal is to be able to do the same as this app does. In our case we currently have defined the email content in email.new_user.php and email.new_user_plain_text.php. Is there a way to do this same as comfortably in the new email template system? A pointer where to find more info would be great, thanks.

But then, how come the app will be supported for NC13? 😄

[nickvergessen]

Yeah so what do you want to change? the text of the email? the layout? add additional info?

If you want to change stuff for all emails, you can overwrite the EmailTemplate in the config with 12.0.1 and later: https://github.com/nextcloud/server/blob/8760abae636b1c6f3f37e78300b318adb98d0220/config/config.sample.php#L969-L974

[GitHubUser4234]

Yeah so what do you want to change? the text of the email? the layout? add additional info?

Text as well as layout.

If you want to change stuff for all emails, you can overwrite the EmailTemplate in the config with 12.0.1 and later: https://github.com/nextcloud/server/blob/8760abae636b1c6f3f37e78300b318adb98d0220/config/config.sample.php#L969-L974

Thanks for the pointer. However it doesn't look like the same, as the text of individual doesn't seem to be editable? And not as convenient as this app where things can be achieved by just quickly modifying some HTML.

It would be really awesome if this app could support NC12, after all support for NC13 is in the cards. It's really sad that with the NC12 upgrade, features like the ones offered by this app are not available anymore 😿

Seems others have also reported this problem:

https://help.nextcloud.com/t/email-templates-missing-nc-12/14356
https://help.nextcloud.com/t/missing-mailtemplate-editor/15114

[fabianblum]

Please update the manual if there is no Theming posibility in the admin page (https://docs.nextcloud.com/server/12/developer_manual/core/theming.html)

[TheMrApostel]

@nickvergessen
But how do i change the existing text?

[TheMrApostel]

Ping

[mrlm-xyz]

@TheMrApostel you can do this via translation layer. But it is a terrible approach!

@nickvergessen as mentioned above please update the manual!!!

@nickvergessen I looked closer at the source code of OC\Mail\EMailTemplate::class and I think it would be worthwhile to remake the mentioned class. A better approach to solve this, would certainly be to retrieve HTML parts individually from external file and not to define HTML as class properties directly in the given container. It is quite logical if we want to use our custom NextCloud theme so that we can also customize the layout of system emails without interfering with the PHP object.

[nickvergessen]

Well the idea is that you create your own EmailTemplate class and then replace it the config.php. Then you can change the HTML as you prefer. For the next version we will add identifiers, so you can also only modify some emails.

And feel free to update the documentation with any changes you need

[SkyWheel]

So, in other words, there is no way to change an email template from web console?

[nickvergessen]

Exactly, it's not there anymore, because if you break the php syntax by missing out a semicolon or something similar, you break sending the email completly.

[TheMrApostel]

Can someone please point me where i can change the code of OC\Mail\EMailTemplate::class?
It is still unclear to me where OC\Mail\EMailTemplate is located on my system.

[mrlm-xyz]

@TheMrApostel it isn't good idea change code in OC\Mail\EMailTemplate::class.

Better way is create your own class like this example:

1. Create your own OC\Mail\EMailTemplate::class extension

<?php namespace MyVendor;

use OC\Mail\EMailTemplate;

class MyClass extends EMailTemplate
{
      // there you can do what will you do
}

2. Then in config/config.php change mail_template_class to your class namespace

'mail_template_class' => MyVendor\MyClass::class

[msberends]

Better way is create your own class like this example:

I find this hard to understand. Where do I save such a PHP file then? Somewhere in my /themes/MyTheme/core folder?

[nickvergessen]

The clean way would be to have a dedicated app for it.
The otherway would be to just throw it into the normal source folder next to the existing one, but that will break with every update. So it's better to create your own app.

@MariusBluem status of the post I gave you?