Skip to content

Conversation

@jancborchardt
Copy link
Member

As discussed @juliushaertl – also found some more stuff than just the alignment of the checkbox. :)

Before After
checkboxes before Checkboxes after

@jancborchardt jancborchardt added bug Something isn't working design Experience, interaction, interface, … 3. to review labels Sep 25, 2020
@jancborchardt jancborchardt added this to the Nextcloud 20 milestone Sep 25, 2020
@jospoortvliet
Copy link
Member

Very nice Jan! I can't test but the css looks sane.

@juliusknorr
Copy link
Member

Looks much nicer, one small suggestion, how about also adjusting the regular lists, so that the bullet points are centered to the checkboxes?

image

@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Sep 28, 2020
@rullzer
Copy link
Member

rullzer commented Sep 28, 2020

master is 21.

@rullzer
Copy link
Member

rullzer commented Sep 28, 2020

/backport to stable20

@jancborchardt
Copy link
Member Author

Looks much nicer, one small suggestion, how about also adjusting the regular lists, so that the bullet points are centered to the checkboxes?

image

I would agree, however this is not possible without hacking one way or the other:
https://stackoverflow.com/questions/4373046/css-control-space-between-bullet-and-li

And this is something which – if at all – we should do separately. :) In the usual cases, bulleted lists and task lists might not immediately follow each other, so it’s not so bad for now.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice

jancborchardt and others added 2 commits September 29, 2020 13:07
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working design Experience, interaction, interface, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants