[master] Render data URL images as-is #2168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Junek <michal@junek.pw>
Signed-off-by: Michal Junek <michal@junek.pw>
DerpgonCz
force-pushed
the
fix/master/image_data_urls
branch
from
4c27851 to
7b420e7
Compare
max-nextcloud
approved these changes
Mar 1, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Same as the PR for stable23. Looks good to me.
Collaborator
|
/rebase |
Collaborator
|
/compile amend / |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the image URL is a data URL, render the image as-is with src="dataUrl". No need to fetch anything.
Also prevents a race condition while loading images.
Related for stable23: #2153
Resolves: #1827