Fix position of dropped images #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
bug
julien-nc
requested review from
juliusknorr,
max-nextcloud,
mejo- and
vinicius73
Member
Author
|
/compile amend |
Member
Author
|
/backport to stable24 |
nextcloud-command
force-pushed
the
fix/drop-image-position
branch
from
1eeacd9 to
1931e2e
Compare
mejo-
approved these changes
Apr 19, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Yay, nice 😍 Works like a charm.
julien-nc
force-pushed
the
fix/drop-image-position
branch
from
1931e2e to
b6087af
Compare
Member
Author
|
/compile amend |
…mage Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/drop-image-position
branch
from
b6087af to
927801e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor position was not set to the drop position so the images were always inserted at the current cursor position.
This required to handle the drop event in the Image node, like we do with the Paste event. The position is then passed to the editor wrapper via a custom event.