Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 24, 2023

ready to merge changes from tests in #4350

  • use postgres for cypress which seems to stabilize the random failures a bit
  • Change step order in mysql setup to give it some more time to be ready
  • Use only github runners for oci for now

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added tests If you write them we ♥ you 3. to review labels Jun 24, 2023
@juliusknorr juliusknorr requested review from blizzz and mejo- June 24, 2023 08:07
@cypress
Copy link

cypress bot commented Jun 24, 2023

2 flaky tests on run #10513 ↗︎

0 147 1 0 Flakiness 2

Details:

ci/flaky runners
Project: Text Commit: 55903fbc48
Status: Passed Duration: 04:06 💡
Started: Jun 24, 2023 8:07 AM Ended: Jun 24, 2023 8:11 AM
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  api/UsersApi.spec.js • 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

Will merge already to see how well this works during dependable updates. Reviews still welcome in case there is feedback I'll follow up.

@juliusknorr juliusknorr merged commit 70f1f2e into main Jun 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the ci/flaky-runners branch June 24, 2023 08:13
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr
Copy link
Member Author

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👌

@mejo-
Copy link
Member

mejo- commented Jun 26, 2023

@juliushaertl shall we do manual backports of this to stable27/26/25?

@juliusknorr
Copy link
Member Author

Yes, maybe combined with the cypress rework once merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review tests If you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants