[stable26] Fade out user cursor labels after five seconds of inactivity #4593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation details:
* Add a custom CollaborationCursor Tiptap extension
* Add CSS to fade out the cursor label after some time.
* Listen for Yjs updates.
- If it's a doc change by ourself, update the timestamp of own user in
awareness state.
- If it's a remote awareness update, add back the CSS class to the
corresponding cursor.
- Wait 50ms before showing the cursor in the DOM to account for cases
where the cursor gets re-rendered by y-prosemirror.
Fixes: #4126
Signed-off-by: Jonas <jonas@freesources.org>
Document changes trigger awareness updates. Wait before sending them in a push request so they can be combined. Also make use of prosemirrors transactions to detect own changes instead of listening to yjs updates. Signed-off-by: Max <max@nextcloud.com>
mejo-
approved these changes
Jul 28, 2023
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 flaky tests on run #11364 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4336