fix(editor): Don't load both Tiptap collaboration history extensions #4621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading Tiptap `extension-history` in RichText.js, let's load it only in `MarkdownContentEditor.vue`. * Editor.vue loads `extension-collaboration` * MarkdownContentEditor.vue loads `extension-history` Fixes: #4601 Signed-off-by: Jonas <jonas@freesources.org>
1 flaky tests on run #11468 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliusknorr
approved these changes
Aug 2, 2023
Member
Author
|
/compile |
Member
Author
|
/backport b9eab5b to stable27 |
Member
Author
|
/backport b9eab5b to stable26 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
|
Awesome, thanks for taking care of that @mejo- ❤️ |
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading Tiptap
extension-historyin RichText.js, let's load it only inMarkdownContentEditor.vue.extension-collaborationextension-historyFixes: #4601
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)