Cache the session info in memcache #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the number of queries to the DB. Esp when editing a file with a lot of people this can really add up. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
juliusknorr
approved these changes
Apr 7, 2020
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks sane and seems to do the trick 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the number of queries to the DB. Esp when editing a
file with a lot of people this can really add up.
In future work we might want to look into a way to only update the DB every 30 seconds or so with the last edit info. I mean it is not super duper crucial this is totally in sync I guess.