Skip to content

Conversation

@benjaminfrueh
Copy link
Contributor

📝 Summary

Increase the messageReconnectTimeout to 70 seconds to account for the 60 second background JS timer throttle in Chromium.

This prevents false connection lost notifications when the editor tab is in the background.

Local tests showed throttled intervals of: 59892ms, 59929ms, 59867ms, 59929ms, 59864ms, 59880ms - consistently under 60 seconds. A 70 second timeout should provide enough buffer.

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@benjaminfrueh benjaminfrueh merged commit 8f7c82a into main Dec 3, 2025
63 checks passed
@benjaminfrueh benjaminfrueh deleted the fix/increase-websocket-timeout branch December 3, 2025 13:01
@benjaminfrueh
Copy link
Contributor Author

/backport to stable32

@benjaminfrueh
Copy link
Contributor Author

/backport to stable31

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants