Skip to content

Check if a file was created manually before creating a new workspace #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Jul 9, 2020
Merged

Check if a file was created manually before creating a new workspace #904

juliusknorr merged 2 commits into from
Jul 9, 2020

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 26, 2020

Steps to reproduce the issue:

  • Create a new directory and open it
  • Manually create a README.md file and add some text to it
  • Click on the rich workspace placeholder to create a new file

Before:

  • A second file was created

After:

  • The rich workspace area will show the content of the existing file

As bonus this makes sure that when using external storages with a case-insensitive file system there will not be two separate files with different casing.

@juliusknorr
Check if a file was created manually before creating a new rich works…
4b3c40b 
…pace

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jun 26, 2020
@juliusknorr juliusknorr requested review from danxuliu and rullzer June 26, 2020 07:17
@juliusknorr juliusknorr added this to the 20.0.0 milestone Jun 26, 2020
@MorrisJobke MorrisJobke modified the milestones: 20.0.0, Nextcloud 20 Jul 7, 2020
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 9, 2020

/compile /

@npmbuildbot
Compile assets
a3295b7 
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
rullzer
rullzer approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@juliusknorr juliusknorr merged commit 1da0582 into master Jul 9, 2020
@juliusknorr juliusknorr deleted the bugfix/noid/rich-workspace-check-before-creating branch July 9, 2020 07:46
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 9, 2020

/backport 4b3c40b to stable19

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 9, 2020

/backport 4b3c40b to stable18

This was referenced Jul 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @rullzer @MorrisJobke