Skip to content

add .php-ini and .php-version to expected files #575

@JohnRDOrazio

Description

@JohnRDOrazio

Even though the two files .php-ini and .php-version are not directly provided by nextcloud, they are however provided by my Plesk setup. It get's a bit annoying to have to move them out of the nextcloud folder in order to do the update, and then move them back in again after. I can't see any counter-indication to including them in the "expected" list?

updater/index.php

Lines 247 to 297 in 3b634b9

private function getExpectedElementsList(): array {
$expected = [
// Generic
'.',
'..',
// Folders
'.reuse',
'.well-known',
'3rdparty',
'apps',
'config',
'core',
'data',
'dist',
'l10n',
'lib',
'LICENSES',
'ocs',
'ocs-provider',
'ocm-provider',
'resources',
'settings',
'themes',
'updater',
// Files
'.rnd',
'index.html',
'indie.json',
'.user.ini',
'composer.json',
'composer.lock',
'console.php',
'cron.php',
'index.php',
'package.json',
'package-lock.json',
'public.php',
'remote.php',
'status.php',
'version.php',
'robots.txt',
'.htaccess',
'AUTHORS',
'CHANGELOG.md',
'COPYING',
'COPYING-AGPL',
'occ',
'db_structure.xml',
];
return array_merge($expected, $this->getAppDirectories());
}

May I create a PR that addresses this?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions