Skip to content

Conversation

@ervee
Copy link
Contributor

@ervee ervee commented Oct 28, 2024

Make the app compatible with Nextcloud 30

Fixes #260

Changes proposed in this pull request:

  • Just a small fix of the appinfo.xml to make it run on NC30. I personally tested the IMAP authentication and did a quick check for changes in authentication API's or something in NC30 but could find none.

Make the app compatible with Nextcloud 30

Signed-off-by: Ralf <ervee@moskovic.org>
@ervee
Copy link
Contributor Author

ervee commented Oct 30, 2024

Hi @violoncelloCH , could you please just merge this and do a quick release for the App Store?

My 2ct about not being able to test properly: People depending on this plugin should really have a test install they can update to NC30 and check if it still works for them. Perhaps mention that in the release note.

@ervee
Copy link
Contributor Author

ervee commented Oct 30, 2024

Or @nickvergessen @ChristophWurst could perhaps?

@nickvergessen
Copy link
Member

I'm not affiliated with the app.

@ervee
Copy link
Contributor Author

ervee commented Oct 30, 2024

I'm sorry about mentioning you then, I thought you were.

@prismopensource
Copy link

Maybe @violoncelloCH could add some extra reviewers with write access?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@hubide
Copy link

hubide commented Jan 7, 2025

Gentle bump up. The request has been approved by @ChristophWurst . @violoncelloCH , do you need to approve it as well? Can it be merge?

We have a bunch of instances to upgrade but are stocked because of user external.

Thank you so much!

@tflidd tflidd merged commit 79ae3e9 into nextcloud:master Mar 10, 2025
@ervee ervee deleted the patch-1 branch March 24, 2025 19:14
@sokai sokai mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nextcloud 30 support

7 participants