.travis.yml and .drone.yml to make automatic CI tests work

[violoncelloCH]

for #24

@MorrisJobke that's what I created...

• .travis.yml is adapted from bookmarks' one
• .drone.yml is the one from apps complemented with parts of user_saml's one

hope that's how they should look like and it's working this way

cc @nextcloud/user_external

[violoncelloCH]

ohh, it looks like travis is already building something

[violoncelloCH]

I removed the composer install because we don't have a composer.json with dependencies, right?

[violoncelloCH]

ant test wanted a build.xml so I took the one from the apps repo

However I'm not sure if we really need ant test (coming from the old apps .travis.yml) if we already have the other tests.
For phpunit in the scripts of .travis.yml, the parameter --configuration phpunit.xml is passed. We don't (yet) have a phpunit.xml. Do we need one or does phpunit run without the parameter?

[MorrisJobke]

If you push a new commit to this branch then the drone job should also start ;)

[violoncelloCH]

The drone sign-off-check on PRs complains about the github_token (The environment variable GITHUB_TOKEN has no proper value.). I don't know if I've done something wrong with the environment variable or if my token I've set in drone settings has not the right permissions. Could you take a look at it @MorrisJobke ?

[violoncelloCH]

for travis:
travis is now failing where I expect it to fail.

• The builds for master don't proceed because we don't yet support NC 16, so I'm not sure if I should rather remove the tests on master or add support for 16?
• The builds on stable15 fail because of occ check-code -- see occ check-code compliance #30
  However I'm not sure if there might be other problems coming after this one is fixed.

[MorrisJobke]

The drone sign-off-check on PRs complains about the github_token (The environment variable GITHUB_TOKEN has no proper value.). I don't know if I've done something wrong with the environment variable or if my token I've set in drone settings has not the right permissions. Could you take a look at it @MorrisJobke ?

That should be handled by the DCO bot. @rullzer Could you add it here?

[MorrisJobke]

travis is now failing where I expect it to fail.

• The builds for master don't proceed because we don't yet support NC 16, so I'm not sure if I should rather remove the tests on master or add support for 16?
• The builds on stable15 fail because of occ check-code -- see occ check-code compliance #30
  However I'm not sure if there might be other problems coming after this one is fixed.

Then for now: comment out the elements in the matrix that runs it on master (re-enable it in a PR that fixes this) and also disable the check-code for now. AFAIK we don't execute it anyways on install as of now.

[violoncelloCH]

That should be handled by the DCO bot.

does this mean I should remove the signed-off-check from drone?

[violoncelloCH]

where went the travis build now? DCO is here (thank you @rullzer), but travis disappeared somehow and doesn't build the new commits

[MorrisJobke]

does this mean I should remove the signed-off-check from drone?

Correct-

[MorrisJobke]

where went the travis build now? DCO is here (thank you @rullzer), but travis disappeared somehow and doesn't build the new commits

Good question ... the hook was properly delivered :/

[MorrisJobke]

Create another commit and push again, maybe it works then.

[violoncelloCH]

Create another commit and push again, maybe it works then.

hmm, doesn't seem to work

[violoncelloCH]

"branches" and "build history" in travis are also empty like...

[violoncelloCH]

whohoo, it works again... I commented out the branches: only: - master as well because I thought this wouldn't be needed with all master builds commented out, but somehow this seemed to be the problem...
now let's see if the build completes...

[violoncelloCH]

For phpunit in the scripts of .travis.yml, the parameter --configuration phpunit.xml is passed. We don't (yet) have a phpunit.xml. Do we need one or does phpunit run without the parameter?

now this is the point where travis fails...
I'll probably just try what happens if I remove the parameter... If we need the parameter I can re-add it at any time...

[violoncelloCH]

okay, that doesn't work
hmm, I'll need some help, sorry... I've no experience with these php unit tests...
The files we have in test/ here look quite different from what I can find in other nextcloud apps... I'll read something about unit testing, but I don't know if I can do this...

[MorrisJobke]

okay, that doesn't work
hmm, I'll need some help, sorry... I've no experience with these php unit tests...
The files we have in test/ here look quite different from what I can find in other nextcloud apps... I'll read something about unit testing, but I don't know if I can do this...

Use this as configuration.xml: https://github.com/nextcloud/apps/blob/master/build.xml

At least this should be a good start. And put the configuration inside the tests directory to make excluding it for build purposes easier. ;)

[violoncelloCH]

thank you very much for your help! @MorrisJobke
phpunit now exits with 0, but says that no tests were executed...
the ones with php coverage fail with Notifying that no code coverage data is available for repository "g/nextcloud/user_external" and revision "2099f41964381b91f1a90b5d7c6bed799851ff78"... Failed { "message": "Not found", "description": "The requested page was not found, or you have no access to view it." }

[violoncelloCH]

@MorrisJobke should I comment out the phpunit tests so we can merge this without them? So we at least have the other tests and can try to get the unit tests to work later... what do you think?

[MorrisJobke]

@MorrisJobke should I comment out the phpunit tests so we can merge this without them? So we at least have the other tests and can try to get the unit tests to work later... what do you think?

Go for that - sorry - don't have time to dig into this.

[violoncelloCH]

@MorrisJobke okay, will do that... no problem! thank you for your support!

[violoncelloCH]

rebased on master and re-enabled drone check-app-compatibility test
please review

[MorrisJobke]

Looks good 👍