fix(env-mode): accept multiple comma-separated groups #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Well, but failing tests look related 😆 |
blizzz
force-pushed
the
fix/293/groups-from-env
branch
from
de834e7 to
4d05f70
Compare
Member
Author
Well, well, the test is questionable in itself 😅 but I adjusted anyway, and could simplify the target method more by reducing a parameter. |
blizzz
force-pushed
the
fix/293/groups-from-env
branch
2 times, most recently
from
c727e97 to
fbbab33
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/293/groups-from-env
branch
from
fbbab33 to
0c0bace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #293
Unlike groups reported via built-in SAML group, those coming in via env var have not been processed correctly.
Supersedes #307