Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 3, 2025

Implement votings on whiteboards. For now we allow plain text as voting options, but may extend this at some point to let people vote on actual elements. Once finished the voting results can be added as bar chart to the whiteboard.

Screenshare

Kapture.2025-02-04.at.17.02.20.webm

@juliusknorr
Copy link
Member Author

@marcoambrosini Some early design feedback would be appreciated

@marcoambrosini
Copy link
Member

Very nice @juliusknorr !
The main thing. I would change here is the wording: from "Voting" to "Poll".
So both the button and the dialog title would say Add new poll.
Also, about the component that ends up in the whiteboard, would it be possible to make it look as much as possible as the one that's in the sidebar?

@juliusknorr
Copy link
Member Author

juliusknorr commented Feb 5, 2025

The main thing. I would change here is the wording: from "Voting" to "Poll".

👍

Also, about the component that ends up in the whiteboard, would it be possible to make it look as much as possible as the one that's in the sidebar?

As a first iteration we are limited to the excalidraw elements (basic shapes for drawing) (similar to the limitations with #278), but we can explore custom rendering separately in the future.

@juliusknorr juliusknorr added enhancement New feature or request 2. developing labels Feb 5, 2025
@juliusknorr juliusknorr moved this to 🏗️ In progress in 📝 Office team Nov 6, 2025
@juliusknorr juliusknorr self-assigned this Nov 6, 2025
@marcoambrosini marcoambrosini self-requested a review November 13, 2025 12:46
@marcoambrosini marcoambrosini moved this to 📐 At design in 🖍 Design team Nov 13, 2025
@juliusknorr juliusknorr force-pushed the feat/voting branch 2 times, most recently from 5d0c593 to 53aef6e Compare December 8, 2025 13:19
marcoambrosini

This comment was marked as resolved.

@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Dec 8, 2025
@juliusknorr juliusknorr added this to the 1.5.0 milestone Dec 9, 2025
@juliusknorr juliusknorr force-pushed the feat/voting branch 2 times, most recently from 6483ce3 to bcf9d48 Compare December 9, 2025 14:51
@juliusknorr juliusknorr marked this pull request as ready for review December 9, 2025 14:51
Comment on lines 23 to 34
export interface VotingStartData {
question: string
type: string
options: string[]
}

export interface VotingVoteData {
votingId: string
optionId: string
}

export interface VotingEndData {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like those interfaces are unused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, let me remove them

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit b959d9c into main Dec 10, 2025
32 checks passed
@juliusknorr juliusknorr deleted the feat/voting branch December 10, 2025 10:37
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Dec 10, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

Status: ☑️ Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants