fix: saving library items #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
luka-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
grnd-alt
approved these changes
Sep 10, 2025
Member
grnd-alt
left a comment
grnd-alt
left a comment
There was a problem hiding this comment.
not tested manually but code is valid 🔥
luka-nextcloud
force-pushed
the
fix-saving-library-items
branch
from
fbbe813 to
bab9b37
Compare
Contributor
|
Much better, thanks @luka-nextcloud!!! But i find can not browse library then add to excalidraw from the excalidraw site (normal download seems worked): with this redirect url: Another thing is the persistency seems only works if user have the Template folder previously. If at root don't have the Template folder seem the libs not got saved Any ideas on those @luka-nextcloud ! |
hweihwang
approved these changes
Sep 10, 2025
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
fix-saving-library-items
branch
from
bab9b37 to
4906d4f
Compare
Contributor
Author
|
@hweihwang Fixed the saving when user don't have the templates folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid saving empty library on first load.