Skip to content

Conversation

@benjaminfrueh
Copy link
Contributor

@benjaminfrueh benjaminfrueh commented Dec 2, 2025

Description

Adds a comment feature for collaborative feedback on whiteboards. This is a first basic implementation and supports simple comment threads.

Features

  • Comment pins draggable, with user avatar and reply count
  • Comment threads with reply, edit, and delete
  • Hover preview for quick comment viewing
  • Comment sidebar for thread overview, navigation and delete
  • Read-only support (no editing and no dragging)

Future enhancements

  • add more e2e tests
  • resolve/unresolve comment threads
  • comment reactions with emoji
  • @ mention users in comments
  • comment search in sidebar

Screenshots

Add new comment Whiteboard-Comment-Feature1
Comment thread and reply Whiteboard-Comment-Feature2
Hover comment preview Whiteboard-Comment-Feature3

@benjaminfrueh benjaminfrueh added enhancement New feature or request 3. to review labels Dec 2, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 2, 2025
@benjaminfrueh benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Dec 2, 2025
@benjaminfrueh benjaminfrueh force-pushed the feat/comments branch 2 times, most recently from 29e0781 to 868f4b6 Compare December 2, 2025 02:20
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Benjamin, really nice!

a few comments:

  • Both comments and smart picker buttons should look like the other buttons in the toolbar, both in hover and active state. Currently they look like this
Screenshot 2025-12-08 at 10 35 44
  • The input field for comments should auto wrap and grow in height when a new line is required instead of becoming a scroll container
Screenshot 2025-12-08 at 11 44 36
  • The comment popover should be movable even if a comment has not been submitted yet. Currently:
Screen.Recording.2025-12-08.at.12.02.40.mov
  • When clicking on a thread in the sidebar, the thread itself should be centered in the content. The following screenshot shows what I see after click:
Screenshot 2025-12-08 at 11 45 26
  • I would flip the comment hover preview so that the avatar is top aligned with the username
Screenshot 2025-12-08 at 11 50 20
  • The send button has dark text in light theme
Screenshot 2025-12-08 at 11 51 34

@juliusknorr juliusknorr added this to the 1.5.0 milestone Dec 9, 2025
@benjaminfrueh benjaminfrueh force-pushed the feat/comments branch 3 times, most recently from 861aa1c to 940416a Compare December 9, 2025 12:26
@benjaminfrueh
Copy link
Contributor Author

Hi @marcoambrosini - thanks for the good feedback! The changes have been implemented now.

As we discussed, I didn't flip the comment hover preview for now, so the avatar remains in place and the pin tail remains at comment XY. Also the button background styling in the toolbar should be addressed in a separate polishing PR, as it's a general UI change not specific to this feature.

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@juliusknorr juliusknorr merged commit 59254ad into main Dec 9, 2025
32 checks passed
@juliusknorr juliusknorr deleted the feat/comments branch December 9, 2025 18:36
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Dec 9, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

4 participants