-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add a comment feature for whiteboards #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29e0781 to
868f4b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Benjamin, really nice!
a few comments:
- Both comments and smart picker buttons should look like the other buttons in the toolbar, both in hover and active state. Currently they look like this
- The input field for comments should auto wrap and grow in height when a new line is required instead of becoming a scroll container
- The comment popover should be movable even if a comment has not been submitted yet. Currently:
Screen.Recording.2025-12-08.at.12.02.40.mov
- When clicking on a thread in the sidebar, the thread itself should be centered in the content. The following screenshot shows what I see after click:
- I would flip the comment hover preview so that the avatar is top aligned with the username
- The send button has dark text in light theme
861aa1c to
940416a
Compare
|
Hi @marcoambrosini - thanks for the good feedback! The changes have been implemented now. As we discussed, I didn't flip the comment hover preview for now, so the avatar remains in place and the pin tail remains at comment XY. Also the button background styling in the toolbar should be addressed in a separate polishing PR, as it's a general UI change not specific to this feature. |
3f71bed to
dd0bd95
Compare
dd0bd95 to
f32bc07
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
f32bc07 to
d97e1ef
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
Adds a comment feature for collaborative feedback on whiteboards. This is a first basic implementation and supports simple comment threads.
Features
Future enhancements
Screenshots
Add new comment
Comment thread and reply
Hover comment preview