fix version-restoring

[hweihwang]

No description provided.

[benjaminfrueh]

Thanks @hweihwang for this fix! I tested this and it worked good for me.

[juliusknorr]

Did you also test explicitly on stable29?

[benjaminfrueh]

Did you also test explicitly on stable29?

Thanks for the reminder, yes I have now and it works as expected. In stable29 it also correctly shows the readonly version preview and restoring versions works generally too - but I have experienced a potential problem and have one question:

When I am connected to a whiteboard with multiple users for collaboration, the version restore seems not to restore anything, maybe because this is synced back from the other connected user immediately then?

[juliusknorr]

When I am connected to a whiteboard with multiple users for collaboration, the version restore seems not to restore anything, maybe because this is synced back from the other connected user immediately then?

@hweihwang Can you elaborate on that?

[hweihwang]

Thanks @benjaminfrueh, @juliusknorr, that's a bug there, restoring using the right side panel without entering the version preview mode should work. But when entering the preview mode, it just got disconnected from the collab socket, so the restore couldn’t broadcast SCENE_RESTORE and the other users’ newer scenes merged back in and overwrote it.

I changed it so we stay connected in preview, please re-test it again, thanks!

[benjaminfrueh]

Hi @hweihwang - this fixes the version restoring for me also during collaboration.

There is another issue I experienced when collaborating: If User A restores a whiteboard, then the canvas of User B gets resized to the size of User A's canvas. This is more obvious if one user restores with a smaller resolution or smaller window size. Maybe this could be improved in a different Issue/PR.