-
Notifications
You must be signed in to change notification settings - Fork 25
redis scaling #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis scaling #848
Conversation
3c99837 to
06b71e6
Compare
|
Currently focus on rebasing and align the logic for Timer and Voting features there, update the progress and description cases above soon cc @juliusknorr |
b9ebbb2 to
4010d2e
Compare
|
Updated there @juliusknorr !!! |
|
Thanks, I'll have a look 👍 |
615a4ba to
52ed669
Compare
| return | ||
| } catch (error) { | ||
| if (this.#isClientClosedError(error)) { | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may hide a critical error, @benjaminfrueh suggested that we may still throw here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added console.error in these cases of silent failures of write operations for now.
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested with and without redis and multiple websocket server nodes.
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
dcfa98c to
b1f697a
Compare
Summary
Rationale
Manual Test Cases