Fixes #161, some bugs with non-8000 port#162
Closed
dconathan wants to merge 15 commits intonextml:masterfrom
dconathan:master
Closed
Fixes #161, some bugs with non-8000 port#162dconathan wants to merge 15 commits intonextml:masterfrom dconathan:master
dconathan wants to merge 15 commits intonextml:masterfrom
dconathan:master
Conversation
Contributor
Author
|
Hold off on merging this until we discuss #161... |
Member
|
We also need to hold off merging because of #154 in which we delete From the files changed I can't tell what happens when |
Contributor
Author
|
Right didn't think about that... if not defined in |
also handles utf8
Contributor
Author
|
This is out of date and conflicts with #166. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so if you specify a different
NEXT_BACKEND_GLOBAL_PORTindocker_up.sh, those changes carry through the appropriate places in thedocker-compose.ymlfile.One thing is to note is that one has to manually set the
NEXT_BACKEND_GLOBAL_PORTenvironment variable when launching an experiment (still defaults to 8000), since presumably that it is in a new environment. We could fix this by making a separatesetup.shorconfig.shscript that sets all the environment variables, whichdocker_up.shandexperiment_triplet.py, etc. could then source...