Merged
Conversation
3 tasks
tsibley
suggested changes
Nov 8, 2022
Contributor
tsibley
left a comment
tsibley
left a comment
There was a problem hiding this comment.
Yay, glad to see this. My idea had been to make this workflow read the RTD config file and install what's configured there, which I still think would be nicer, but it's more complex.
victorlin
force-pushed
the
victorlin/docs-ci/add-pip-install
branch
from
fa0bf2b to
f1a8182
Compare
Some docs projects use pip instead of conda to set up the environment. 1. Make environment-file input (Conda setup) optional. 2. Add a new optional input to install from pip. 3. Use one job per environment setup option. Specifying none of the setup options will cause both jobs to be skipped, but I think that's appropriate user error.
victorlin
force-pushed
the
victorlin/docs-ci/add-pip-install
branch
from
f1a8182 to
79386fb
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Some docs projects use pip instead of conda to set up the environment.
Make environment-file input (Conda setup) optional.
Add a new optional input to install from pip.
Use one job per environment setup option.
Specifying none of the setup options will cause both jobs to be skipped, but I think that's appropriate user error.
Related issue(s)
Testing