Merged
Conversation
Not expecting any maliciousness but potentially accidental escape of the naive single quoting.
This will let us run pathogen repo CI in both our Docker and Conda runtimes, for example. Docker is still the default.
Contains potentially useful debugging information.
Necessary to avoid mixing up/overwriting build results when this workflow is invoked multiple times from the same calling workflow.
It's helpful to test that our pathogen repos work on all supported runtimes. This commit doesn't change the existing default of only using the Docker runtime. The default will be changed in a subsequent commit, however.
This is our other major runtime, and it seems worth the extra CI time to routinely test on it. We may want to add the Singularity runtime at some point too, but that would require additional runner setup work.
This was referenced May 11, 2023
Merged
Contributor
Author
|
This might reveal bugs in our Conda runtime for ncov and seasonal-flu: nextstrain/conda-base#27 (comment) |
victorlin
approved these changes
May 12, 2023
Comment on lines
+50
to
+52
| containing YAML. This is easily produced, for example, by pretending | ||
| you're writing normal nested YAML within a literal multi-line block | ||
| scalar (introduced by "|"): |
Member
There was a problem hiding this comment.
Neat workaround for input type limitations.
joverlee521
reviewed
May 12, 2023
Comment on lines
+106
to
+108
| strategy: | ||
| matrix: | ||
| runtime: ${{ fromJSON(needs.configuration.outputs.runtimes) }} |
Contributor
There was a problem hiding this comment.
Thoughts on adding fail-fast: false so that runtime failures do not interfere with each other?
Contributor
Author
There was a problem hiding this comment.
Yep, that makes sense. Would you do it?
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages.
Testing