Skip to content

Remove intentional failure test #48 #58#85

Merged
genehack merged 1 commit intomasterfrom
remove-fail-tests-58
May 16, 2024
Merged

Remove intentional failure test #48 #58#85
genehack merged 1 commit intomasterfrom
remove-fail-tests-58

Conversation

@genehack
Copy link
Copy Markdown
Contributor

@genehack genehack commented May 15, 2024

Per Jover,

This is testing the workaround for continue-on-error added in #40
works as expected. Reading through that discussion again, @tsibley
had noted that we can eventually remove the test.

The workaround has been working for a ~year now, so I think it's
safe to remove the test now!

@genehack genehack requested review from a team and tsibley May 15, 2024 16:54
@genehack
Remove intentional failure test #48 #58
e0efff7 
Per Jover,

> This is testing the workaround for continue-on-error added in #40
> works as expected. Reading through that discussion again, @tsibley
> had noted that we can eventually remove the test.

> The workaround has been working for a ~year now, so I think it's
> safe to remove the test now!
@genehack genehack force-pushed the remove-fail-tests-58 branch from 2cd5d7f to e0efff7 Compare May 15, 2024 16:56
@genehack genehack mentioned this pull request May 15, 2024
Closed
@genehack
Copy link
Copy Markdown
Contributor Author

genehack commented May 15, 2024

🎉 Screenshot 2024-05-15 at 10 36 06

@genehack genehack merged commit f996c9b into master May 16, 2024
@genehack genehack deleted the remove-fail-tests-58 branch May 16, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

@tsibley tsibley Awaiting requested review from tsibley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@genehack @joverlee521