volume: store_volume("X") no longer sets opts.X #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsibley
force-pushed
the
trs/build/workflows-in-subdirs
branch
from
bf858d2 to
fc2afdf
Compare
The volume named "X" is now only appended to the opts.volumes list. The last usage of the prior functionality, for opts.build, was removed in "Better support pathogen repositories which place workflows in subdirectories" (bf858d2). I think this clarifies a potentially-confusing part of the argument parsing too (e.g. "where did opts.X come from?").
tsibley
force-pushed
the
trs/dev/trash-unused-volumes-code-path
branch
from
e06e31d to
642adf9
Compare
victorlin
approved these changes
May 8, 2024
Contributor
Author
|
@victorlin Thanks for your comment. I'd totally forgotten about this minor change and hadn't swept the PR list recently for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volume named "X" is now only appended to the
opts.volumeslist.The last usage of the prior functionality, for
opts.build, was removed in "Better support pathogen repositories which place workflows in subdirectories" (bf858d2).I think this clarifies a potentially-confusing part of the argument parsing too (e.g. "where did
opts.Xcome from?").Related issue(s)
Based on #355.
Checklist