Skip to content

runner.conda: Ignore newly failing type check for tarfile.open() #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsibley merged 1 commit into from
Sep 5, 2024
Merged

runner.conda: Ignore newly failing type check for tarfile.open() #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nextstrain/cli/runner/conda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def setup_micromamba(dry_run: bool = False, force: bool = False) -> bool:
assert content_type == "application/x-tar", \
f"unknown content-type for micromamba dist: {content_type}"

with tarfile.open(fileobj = response.raw, mode = "r|*") as tar:
with tarfile.open(fileobj = response.raw, mode = "r|*") as tar: # type: ignore
# Ignore archive members starting with "/" and or including ".." parts,
# as these can be used (maliciously or accidentally) to overwrite
# unintended files (e.g. files outside of MICROMAMBA_ROOT).
Expand Down