feat(ingest): store translations as .tar.zst instead of .zip#49
Open
corneliusroemer wants to merge 1 commit intomainfrom
Open
feat(ingest): store translations as .tar.zst instead of .zip#49corneliusroemer wants to merge 1 commit intomainfrom
.tar.zst instead of .zip#49corneliusroemer wants to merge 1 commit intomainfrom
Conversation
In general, we should use zst over zip/gzip/xz due to faster (de)compression and also often higher compression ratios (for longer sequences). While the default compression with .tar.zst is slightly less dense than .zip, this is tunable and with e.g. -10 we get smaller outputs My suggestion is to use .tar.zst for a uniform API across nextstrain ingest outputs - in this case here it doesn't matter as it's just 100kB anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, we should use zst over zip/gzip/xz due to faster (de)compression and also often higher compression ratios (for longer sequences).
While the default compression with .tar.zst is slightly less dense than .zip, this is tunable and with e.g. -10 we get smaller outputs
My suggestion is to use .tar.zst for a uniform API across nextstrain ingest outputs - in this case here it doesn't matter as it's just 100kB anyways.
Description of proposed changes
Related issue(s)
Checklist