Skip to content

fix: annotations is a file not a param#157

Merged
j23414 merged 1 commit intomasterfrom
fix_annotations_path
Jun 15, 2023
Merged

fix: annotations is a file not a param#157
j23414 merged 1 commit intomasterfrom
fix_annotations_path

Conversation

@j23414
Copy link
Copy Markdown
Contributor

@j23414 j23414 commented Jun 9, 2023

Description of proposed changes

I was wondering why the dot was needed in

  annotations: './source-data/annotations.tsv'

and not in

  local_geolocation_rules: 'source-data/geolocation-rules.tsv'

The answer is that 'local_geolocation_rules" were marked as input files in the snakemake rule.

This change marks the annotation as an input file, basically to be consistent with the changes in #153

Related issue(s)

Testing

  • Checks pass

@j23414 j23414 requested a review from a team June 9, 2023 23:04
@j23414
Copy link
Copy Markdown
Contributor Author

j23414 commented Jun 10, 2023

Manual check seems to pass.

git clone https://github.com/nextstrain/monkeypox.git original
git clone https://github.com/nextstrain/monkeypox.git changed

cd original/ingest
nextstrain build . 

cd ../../changed/ingest
git checkout fix_annotations_path
nextstrain build . 

diff data/metadata.tsv ../../original/ingest/data/metadata.tsv | less # no changes

@j23414 j23414 merged commit 62fca49 into master Jun 15, 2023
@j23414 j23414 deleted the fix_annotations_path branch June 15, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants