Use centralized script for transform strain names#182
Merged
Conversation
victorlin
approved these changes
Sep 20, 2023
Member
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
Looks good to me pending successful tests!
subrepo: subdir: "ingest/vendored" merged: "c02fa81" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "c02fa81" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
j23414
force-pushed
the
centralize_transform_strain_names
branch
from
b078b4b to
52d75f4
Compare
Contributor
Author
|
Tests pass, and metadata.tsv shows no differences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
transform-strain-namesscript has been moved to the centralized ingest repo. Remove the copy in this repo and update references.Related issue(s)
Testing
cd ingest; nextstrain build --cpus 1 . data/metadata.tsvruns locally