Simplify installation and build invocation; add CI#8
Merged
Conversation
…tall instructions Uses an alternate runtime image with Nextalign v2 already baked in.
tsibley
changed the title
Simplifies invocation for the usual case.
tsibley
changed the title
victorlin
approved these changes
May 23, 2022
Member
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
Looks good with the update to @master once nextstrain/.github#23 is merged.
tsibley
force-pushed
the
trs/simplified-install
branch
from
61c15b0 to
01c4481
Compare
| sudo cp target/release/nextalign /usr/local/bin/ | ||
| ``` | ||
| Follow the [standard installation instructions](https://docs.nextstrain.org/en/latest/install.html) for Nextstrain's suite of software tools. | ||
| Please choose the installation method for your operating system which uses Docker, as currently a pre-release version of Nextalign is required which we've baked into the `--image` argument to `nextstrain build` above. |
Member
There was a problem hiding this comment.
Maybe we should add something more explicit to nextstrain build. I just get the following which doesn't tell me much about what the problem is:
Warning: The specified --image=nextstrain/base:branch-nextalign-v2 option is not used by --native.
Just running the command, but probably missing docker. Warning should tell me what the problem is.
Member
There was a problem hiding this comment.
The warning should be:
Falling back to `--native` since `--docker` does not seem to be available.
Check your setup by running `nextstrain check-setup --set-default`
Contributor
Author
There was a problem hiding this comment.
Followup to these comments happened in Slack, where the comments were cross-posted.
3 tasks
victorlin
pushed a commit
that referenced
this pull request
Jul 28, 2023
Add simple Slack notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses an alternate runtime image with Nextalign v2 already baked in.
Also simplified the invocation so the default config file is used by default.
Also added CI to help ensure the build works in the face of changes (from pushes and PRs).
Related issue(s)
Related to nextstrain/docker-base#43 and nextstrain/.github#23.
Testing
nextstrain buildcommand shown works for me.