Conversation
victorlin
reviewed
May 5, 2023
Member
There was a problem hiding this comment.
Just to clarify, 342ead8 is copying from nextstrain/dengue#6 which copies from the monkeypox repo in nextstrain/dengue@4b19154 and makes additional changes?
Contributor
Author
There was a problem hiding this comment.
Haha, yes! I wish there was a simpler way
Future commits will change this to work with zika data
Since the original zika ingest only pulled data from 2013 onward, modify the genbank-url script to only pull data from 2013 onward.
Since Ingest pushes data to a different endpoint, update zika build to pull from the new endpoint. Other modifications from the original described below: Since strains (or isolates) may be re-sequenced resulting in duplicate strain names breaking Nextstrain builds, other pathogen repos (e.g. Monkeypox) had switched to indexing records by GenBank ID instead (`rule wrangle_metdata`) and swapping in the final strain name at the end (`rule final_strain_name`) and Zika was updated accordingly. Other changes include updating the list of dropped strain names to GenBank IDs (where the original strain names moved to comments) and updating the example sequence fasta headers. In addition, added the strain name as a Tip Label dropdown item as discussed in: #25 (comment)
j23414
force-pushed
the
ingest
branch
2 times, most recently
from
6842ed2 to
fd166ba
Compare
Rescue some of the original functionality of the zika_upload script from fauna. https://github.com/nextstrain/fauna/blob/master/vdb/zika_upload.py#L14-L30 * Remove monkeypox annotations.tsv * Move strain name, location, and date fixes to annotations.tsv * Match strain names in fauna database * Match locations in fauna database if both region and country names do not match * Match dates in fauna database unless genbank has been updated
7 tasks
Contributor
Author
|
There have been changes to how we add ingest so closing this PR. A new attempt can start from a blank slate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Testing
If reviewer wants to run a local check as documented in ingest/README.md and README.md: