fix: resolve S3 publishing failures and publishDir configuration casting errors#178
Open
edmundmiller wants to merge 4 commits intomainfrom
Open
fix: resolve S3 publishing failures and publishDir configuration casting errors#178edmundmiller wants to merge 4 commits intomainfrom
edmundmiller wants to merge 4 commits intomainfrom
Conversation
fd8aad0 to
99078ba
Compare
FriederikeHanssen
approved these changes
Sep 22, 2025
99078ba to
87c97dd
Compare
Contributor
Author
|
Branch rebased onto latest main to resolve conflicts. |
…ing errors - Add multipart upload permissions to S3 IAM policy for large files >5GB - Remove problematic closures from publishDir tags configuration - Update policy version hash to trigger compute environment recreation - Fixes workflow failures with S3 copy operations and casting errors
…nings - Add account="" to 1Password provider to prevent CLI account detection conflict - Refactor S3 bucket to use separate BucketServerSideEncryptionConfigurationV2 resource - Refactor S3 bucket to use separate BucketVersioningV2 resource - Remove deprecated inline server_side_encryption_configuration parameter - Remove deprecated inline versioning parameter Fixes "Config conflict: serviceAccountToken and account are set" error by explicitly disabling account detection when using service account tokens. Resolves AWS deprecation warnings by moving encryption and versioning configuration to dedicated resources as recommended by AWS provider. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
87c97dd to
fd56556
Compare
- Update IAM policy to restrict CI user access to modules/* prefix only - Split policy into separate bucket-level and object-level statements - Add StringLike condition for s3:prefix on ListBucket operations - Restrict PutObject and GetObject to modules/* resource path only - Remove s3:PutObjectAcl permission (not needed for basic uploads) - Update policy description to reflect modules/ prefix restriction Security improvements: - CI user cannot access bucket root or other prefixes - Can only list/read/write within s3://nf-core-co2-reports/modules/* - Minimal permissions following principle of least privilege - S3 versioning still preserves all file versions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Addresses two critical issues identified in the AWSMegatests workflow failures:
Root Causes
S3 Publishing Failures
Configuration Casting Errors
Solution
Enhanced S3 Permissions
Fixed publishDir Configuration
Files Changed
Testing
Impact
Fixes the workflow failure reported by Seqera AI.