Rebased ASR for LFM2-Audio-1.5B#58
Closed
tdakhran wants to merge 3 commits intongxson:xsn/mtmd_refactor_audio_preprocfrom
Closed
Rebased ASR for LFM2-Audio-1.5B#58tdakhran wants to merge 3 commits intongxson:xsn/mtmd_refactor_audio_preprocfrom
tdakhran wants to merge 3 commits intongxson:xsn/mtmd_refactor_audio_preprocfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tdakhran
force-pushed
the
tarek/feat/lfm2_asr_rebased
branch
from
47d584e to
2c56532
Compare
ngxson
reviewed
Dec 15, 2025
ngxson
reviewed
Dec 15, 2025
Owner
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
Looking good overall, just a small comment about preprocessing need to be a dedicated class
tdakhran
force-pushed
the
tarek/feat/lfm2_asr_rebased
branch
from
2c56532 to
50597aa
Compare
Author
|
pushed into ggml-org#17694 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.