Open
Conversation
m-akinc
commented
Jan 29, 2026
Contributor
Author
There was a problem hiding this comment.
Won't submit until all Angular upgrade PRs are queued up and ready.
jattasNI
reviewed
Feb 2, 2026
change/@ni-eslint-config-angular-88db44c6-80da-4faa-94ca-0cc9a261fd43.json
Show resolved
Hide resolved
rajsite
reviewed
Feb 9, 2026
rajsite
reviewed
Feb 9, 2026
tests/angular/projects/angular-library/src/lib/angular-library.component.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only rule changes are as follows:
@angular-eslint/component-class-suffixremoved (waserror)@angular-eslint/directive-class-suffixremoved (waserror)We also have a new recommended rule that we are disabling:
@angular-eslint/prefer-injectApparently, using the
inject()function is recommended over injection as constructor arguments. Angular even provides an automatic migration (ng generate @angular/core:inject), but it's not smart. It just puts new fields immediately before the constructor, but they need to be declared/initialized before any other field initializers that depend on them. For automation purposes (and probably as general convention), that means we want them declared at the top of the class.@typescript-eslint/member-orderingdoesn't have an automated fix-up, nor the ability to take initializers into acount. The Perfectionistsort-classesrule has both of those, so I optimistically tried using that instead. We can configure their rule to enforce (and automate the sorting of) fields initialized withinject(...coming before all other fields. But I wasn't able to prevent it from auto-sorting getter/setter pairs with different access modifiers apart from each other (which is also a violation).Aside from this it's unclear how painful it would be to update unit test code that might be constructing these objects directly. Based on all this, I'm disabling the rule.