Skip to content

Fix config/output type URLs #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavidCurtiss merged 13 commits into from
Oct 25, 2024
Merged

Fix config/output type URLs #1002

DavidCurtiss merged 13 commits into from
Oct 25, 2024

Conversation

@DavidCurtiss
Copy link
Collaborator

@DavidCurtiss DavidCurtiss commented Oct 21, 2024 •
edited
Loading

What does this Pull Request accomplish?

  • Updates the type_url of the Configurations and Outputs of the measurement, as returned by GetMetadata
  • Checks the type_url of the request's connection_parameters, and prints a warning to stderr if there's a mismatch

Why should this Pull Request be merged?

Fixes #890

What testing has been done?

  • Tested with GameOfLife_Python and the C# GameOfLife that the measurements work and do not print warnings
  • Tested modifying the client and server side of GameOfLife_Python to expect a different type_url, and saw the warnings

@DavidCurtiss
Require correct type_url
7af8c84 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Update meas signature; downgrade param validation to warn
297b124 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss DavidCurtiss changed the title Require correct type_url Fix config/output type URLs Oct 23, 2024
@DavidCurtiss
ni-python-styleguide
2eeb0b7 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Fix copy/paste missing change
f817d9e 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
bkeryan
bkeryan requested changes Oct 23, 2024
View reviewed changes
@DavidCurtiss
Brad's
a3f0d5c 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Set type_url in some tests
51217a9 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Fix more tests
0de2a36 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Use advertised message type
3ffa1f9 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Fix/filter warnings
45fbc08 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
styleguide
d34446d 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Filter more warnings; remove accidentally-added swap files
c3c0616 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
bkeryan
bkeryan requested changes Oct 24, 2024
View reviewed changes
@DavidCurtiss
Remove extra blank lines in tests
3cb7c3e 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
@DavidCurtiss
Change usefixtures decorators to be file-global instead
9c1ed86 
Signed-off-by: David Curtiss <david.curtiss@ni.com>
bkeryan
bkeryan approved these changes Oct 25, 2024
View reviewed changes
@DavidCurtiss DavidCurtiss merged commit 7f38be6 into ni:main Oct 25, 2024
@DavidCurtiss DavidCurtiss deleted the require-type-url branch October 25, 2024 16:37
@DavidCurtiss DavidCurtiss mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python services return incorrect message type names from GetMetadata RPC

2 participants

@DavidCurtiss @bkeryan