Replace ni.protobuf.types stubs with dependency on ni.protobuf.types package #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them in from ni.protobuf.types Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
Test Results 52 files ±0 52 suites ±0 1h 17m 1s ⏱️ - 2m 19s Results for commit a011964. ± Comparison against base commit 37355e1. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mjohanse-emr
commented
Aug 13, 2025
Collaborator
Author
mjohanse-emr
left a comment
mjohanse-emr
left a comment
There was a problem hiding this comment.
I'm unsure about these pyproject.toml changes. I did what I had to do to get poetry lock to succeed.
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
requested changes
Aug 13, 2025
bkeryan
reviewed
Aug 13, 2025
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Show resolved
Hide resolved
added 5 commits
August 13, 2025 15:25
…and ni.panels.v1. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…yleguide exclude list since they don't conform to the styleguide as generated. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
mjohanse-emr
commented
Aug 15, 2025
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
mjohanse-emr
requested review from
csjall,
dixonjoel and
mshafer-NI
as code owners
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
reviewed
Aug 15, 2025
bkeryan
approved these changes
Aug 15, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
mjohanse-emr
changed the title
dixonjoel
reviewed
Aug 15, 2025
dixonjoel
approved these changes
Aug 15, 2025
Collaborator
dixonjoel
left a comment
dixonjoel
left a comment
There was a problem hiding this comment.
Approved with suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
ni/protobuf/typesni/panels/v1ni.protobuf.typespackage.ni-protobuf-typesto the generator and the service. Also to two examples.generatorto change imports to point to theni.protobuf.typespackage.ni.panels.v1, so I didn't make any changes or add a dependency on theni-panels-v1-protopackage.ni/protobuf/typesandni/panels/v1paths when generating stubs.Why should this Pull Request be merged?
AB#3229834
What testing has been done?
Unit tests, system tests, mypy, styleguide.
I have not done any manual testing.