Skip to content

Conversation

@mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Sep 11, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add LibraryInterpreter.write_analog_waveform() and LibraryInterpreter._internal_write_analog_waveform_per_chan()
  • Add AnalogSingleChannelWriter.write_waveform()
  • Add support in Task.write() for AnalogWaveform
  • Made feature_toggle.raise_if_disabled() public

Why should this Pull Request be merged?

AB#3258807

What testing has been done?

for AnalogSingleChannelWriter:

test___analog_single_channel_reader___read_waveform_feature_disabled___raises_feature_not_supported_error
test___analog_single_channel_writer___write_waveform___updates_output
test___analog_single_channel_writer___write_waveform_with_float32_dtype___updates_output
test___analog_single_channel_writer___write_waveform_with_scaling___updates_output
test___analog_single_channel_writer___write_waveform_with_non_contiguous_data___updates_output

for Task:

test___task___write_waveform_feature_disabled___raises_feature_not_supported_error
test___task___write_linear_ramp_waveform___output_matches_final_value
test___task___write_waveform_with_auto_start___waveform_executes_successfully
test___task_with_multiple_channels___write_single_channel_waveform___raises_daq_error
test___task___write_waveform_with_float32_dtype___output_matches_final_value
test___task___write_waveform_with_scaling___output_matches_final_value
test___task___write_waveform_with_non_contiguous_data___updates_output
test___task___write_waveform_with_timing___all_samples_match_waveform_data

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Test Results

    38 files  ±  0      38 suites  ±0   1h 2m 45s ⏱️ -32s
 2 709 tests + 26   2 236 ✅ ±0    473 💤 + 26  0 ❌ ±0 
47 680 runs  +274  40 210 ✅ ±0  7 470 💤 +274  0 ❌ ±0 

Results for commit 4b74acb. ± Comparison against base commit 922dce2.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review September 11, 2025 21:06
@mikeprosserni mikeprosserni merged commit b07a8d1 into master Sep 12, 2025
27 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/task-3258807-analog-single-waveform-writer branch September 12, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants