Skip to content

Conversation

@texasaggie97-zz
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • When we quit copying examples and system_tests to generated, we no longer had flake8 coverage of these folders
  • Run flake8 on system_tests and examples for each driver

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • flake8

Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really obnoxious that we need to unroll the same thing for each module... twice!

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #1283 into master will decrease coverage by 5.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   91.69%   86.25%   -5.44%     
==========================================
  Files          20       18       -2     
  Lines        3695     4162     +467     
==========================================
+ Hits         3388     3590     +202     
- Misses        307      572     +265     
Flag Coverage Δ
#codegenunittests ?
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 51.72% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 95.90% <ø> (-0.20%) ⬇️
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.83% <ø> (-0.18%) ⬇️
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.78% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
generated/nitclk/nitclk/session.py 95.45% <0.00%> (-2.06%) ⬇️
generated/nifake/nifake/session.py 97.74% <0.00%> (ø) ⬆️
generated/nifake/nifake/_converters.py 96.59% <0.00%> (ø) ⬆️
build/helper/documentation_helper.py
build/helper/parameter_usage_options.py
build/helper/metadata_find.py
build/helper/documentation_snippets.py
build/helper/__init__.py
build/helper/metadata_add_all.py
build/helper/metadata_merge_dicts.py
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4cfce...162d6e8. Read the comment docs.

@texasaggie97-zz texasaggie97-zz merged commit 1279584 into master Feb 19, 2020
@texasaggie97-zz texasaggie97-zz deleted the flake8-examples-system-tests branch February 19, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants