Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Apr 17, 2020

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds nidigital system test test_create_get_delete_time_sets
    • Covers create_time_set, get_time_set_name, delete_all_time_sets
  • Adds nidigital system test test_configure_get_time_set_period
    • Covers configure_time_set_period, get_time_set_period
  • Adds nidigital system test test_configure_get_time_set_drive_format
    • Covers configure_time_set_drive_format, get_time_set_drive_format
  • Adds nidigital system test test_configure_get_time_set_edge
    • Covers configure_time_set_edge, get_time_set_edge
  • Adds nidigital system test test_configure_time_set_drive_edges
  • Adds nidigital system test test_configure_time_set_compare_edges_strobe
  • Adds nidigital system test test_configure_get_time_set_edge_multiplier
    • Covers configure_time_set_edge_multiplier, get_time_set_edge_multiplier
  • Adds nidigital system test test_configure_time_set_drive_edges2x
  • Adds nidigital system test test_configure_time_set_compare_edges_strobe2x

List issues fixed by this Pull Request below, if any.

What testing has been done?

Ran the new system tests on a system with nidigital 19.0.1 installed.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1414   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          20       20           
  Lines        3642     3642           
=======================================
  Hits         3347     3347           
  Misses        295      295           
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nifakeunittests 96.36% <ø> (ø)
#nimodinstunittests 95.37% <ø> (ø)
#nitclkunittests 95.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efeaf9d...b0abdf4. Read the comment docs.

@ni-jfitzger
Copy link
Collaborator Author

Github was having issues when I pushed my latest changes, so they're not appearing.

@sbethur sbethur merged commit b35ab16 into ni:master Apr 23, 2020
@ni-jfitzger ni-jfitzger deleted the nidigital/time_set_tests branch April 23, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants