Skip to content

Conversation

@sbethur
Copy link
Contributor

@sbethur sbethur commented Apr 18, 2020

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Fix a typo in convert_repeated_capabilities_without_prefix() docstring

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

CI will run the tests

@sbethur sbethur requested a review from marcoskirsch April 18, 2020 20:01
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #1415 into master will decrease coverage by 1.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   91.90%   90.39%   -1.51%     
==========================================
  Files          20       31      +11     
  Lines        3642     6993    +3351     
==========================================
+ Hits         3347     6321    +2974     
- Misses        295      672     +377     
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 70.69% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.36% <ø> (ø)
#nifgensystemtests 96.91% <ø> (?)
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.37% <ø> (ø)
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
generated/nifake/nifake/_converters.py 96.61% <ø> (ø)
generated/nitclk/nitclk/_library.py 100.00% <0.00%> (ø)
generated/nifgen/nifgen/_library.py 96.91% <0.00%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0.00%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0.00%> (ø)
generated/niscope/niscope/_library.py 86.69% <0.00%> (ø)
generated/nise/nise/_library.py 100.00% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 69.35% <0.00%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0.00%> (ø)
generated/nidcpower/nidcpower/_library.py 98.58% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e3230...34e2d41. Read the comment docs.

@marcoskirsch marcoskirsch merged commit 05fee0c into master Apr 23, 2020
@marcoskirsch marcoskirsch deleted the fix_typo_in_converter_docstring branch April 23, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants