Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds test test_create_source_waveform_serial
  • Adds test test_create_source_waveform_from_file_tdms
  • Adds test test_write_source_waveform_data_from_file_tdms
  • Adds test test_create_capture_waveform_serial
  • Adds test test_create_capture_waveform_from_file_digicapture

List issues fixed by this Pull Request below, if any.

What testing has been done?

Ran system tests on a system with ni-digital 19.0.1 installed.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #1431 into master will increase coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   91.90%   92.80%   +0.90%     
==========================================
  Files          20       30      +10     
  Lines        3642     6423    +2781     
==========================================
+ Hits         3347     5961    +2614     
- Misses        295      462     +167     
Flag Coverage Δ
#codegenunittests 88.24% <ø> (ø)
#nidcpowersystemtests 98.58% <ø> (?)
#nidigitalsystemtests 95.37% <ø> (?)
#nidmmsystemtests 95.48% <ø> (?)
#nifakeunittests 96.40% <ø> (+0.03%) ⬆️
#nimodinstsystemtests 87.23% <ø> (?)
#nimodinstunittests 95.37% <ø> (ø)
#niscopesystemtests 83.15% <ø> (?)
#nisesystemtests 100.00% <ø> (?)
#niswitchsystemtests 98.11% <ø> (?)
#nitclksystemtests 100.00% <ø> (?)
#nitclkunittests 95.45% <ø> (ø)
Impacted Files Coverage Δ
generated/niswitch/niswitch/_library.py 98.11% <0.00%> (ø)
generated/nidigital/nidigital/_library.py 95.16% <0.00%> (ø)
generated/nitclk/nitclk/_library.py 100.00% <0.00%> (ø)
generated/nidcpower/nidcpower/_library.py 98.58% <0.00%> (ø)
generated/nimodinst/nimodinst/_library.py 87.23% <0.00%> (ø)
generated/nise/nise/_library.py 100.00% <0.00%> (ø)
generated/niscope/niscope/_library.py 86.69% <0.00%> (ø)
generated/niscope/niscope/waveform_info.py 57.35% <0.00%> (ø)
...digital/nidigital/history_ram_cycle_information.py 100.00% <0.00%> (ø)
generated/nidmm/nidmm/_library.py 95.48% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd2bd1...0853cbd. Read the comment docs.

@ni-jfitzger
Copy link
Collaborator Author

@sbethur Please review this PR very carefully. The tests pass, but I really have no idea what I'm doing or how these methods really work. I just stole code from other tests and messed with it until it passed. There's a fair chance that I missed, messed up or overlooked something that matters outside the execution of the methods being tested.

…e using its project to use a new project with appropriate configuration.
…correcting waveform data written to match pattern size
@ni-jfitzger
Copy link
Collaborator Author

Note that between the renamed test_files project and the new test_create_capture_waveform_serial project, some files may be exactly the same, leading Git to be confused about which file was renamed and which was added.

@sbethur
Copy link
Contributor

sbethur commented Apr 27, 2020

test this please

@sbethur sbethur merged commit 4d27237 into ni:master Apr 27, 2020
@ni-jfitzger ni-jfitzger deleted the nidigital/source_and_capture_memory_tests branch April 28, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants