-
Notifications
You must be signed in to change notification settings - Fork 99
Add nidigital system tests for remaining source and capture methods #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nidigital system tests for remaining source and capture methods #1431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
==========================================
+ Coverage 91.90% 92.80% +0.90%
==========================================
Files 20 30 +10
Lines 3642 6423 +2781
==========================================
+ Hits 3347 5961 +2614
- Misses 295 462 +167
Continue to review full report at Codecov.
|
|
@sbethur Please review this PR very carefully. The tests pass, but I really have no idea what I'm doing or how these methods really work. I just stole code from other tests and messed with it until it passed. There's a fair chance that I missed, messed up or overlooked something that matters outside the execution of the methods being tested. |
…ital/source_and_capture_memory_tests
…e using its project to use a new project with appropriate configuration.
…correcting waveform data written to match pattern size
|
Note that between the renamed test_files project and the new test_create_capture_waveform_serial project, some files may be exactly the same, leading Git to be confused about which file was renamed and which was added. |
|
test this please |
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull request
What does this Pull Request accomplish?
test_create_source_waveform_serialtest_create_source_waveform_from_file_tdmstest_write_source_waveform_data_from_file_tdmstest_create_capture_waveform_serialtest_create_capture_waveform_from_file_digicaptureList issues fixed by this Pull Request below, if any.
What testing has been done?
Ran system tests on a system with ni-digital 19.0.1 installed.